Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InitialBaseLines not working correctly with a comma in the a baselinename #125

Open
lenntt opened this issue Aug 7, 2017 · 2 comments
Open
Labels

Comments

@lenntt
Copy link

lenntt commented Aug 7, 2017

I couldn't get the way the InitialBaseLines configuration to work, presumably because my baselines contain a comma. The code literally splits by comma in configuration.py.

Configuration:

InitialBaseLines = my_component = "Baseline_#1,123"

My workaround:
Since I just have one component,
I removed the split on a comma in getinitialcomponentbaselines

@WtfJoke WtfJoke added the bug label Aug 8, 2017
@WtfJoke
Copy link
Member

WtfJoke commented Aug 8, 2017

Hi Len

Thanks for your report. I missed that case when I implemented that feature.

Need to do some brainstorming, how it could be implemented better.

@lenntt
Copy link
Author

lenntt commented Aug 8, 2017

I can imagine the tricky part is to stay backwards compatible with currently working configurations.

Otherwise I'd say: newlines are perhaps a bit safer.
Or - this would be my own choice - go with a more standard format (and parser) that supports mapping-like data (e.g. yaml), so you don't need to bother about these kind of things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants