Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

amp-animation imported when not used, breaking AMP compatibility #471

Open
amedina opened this issue May 11, 2021 · 2 comments
Open

amp-animation imported when not used, breaking AMP compatibility #471

amedina opened this issue May 11, 2021 · 2 comments
Assignees

Comments

@amedina
Copy link
Collaborator

amedina commented May 11, 2021

Report from user: I tried the Story ad creation tool today, it's very easy to use! I checked the downloaded zip of a simple story ad out and realized that amp-animation custom element is imported even when it isn't used. This will break amp validity and reject upload in DV360. Can we possibly address this?

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance Criteria

Implementation Brief

@divyarajmasani
Copy link

A fix for the issue has been pushed and available on

https://rtcamp.github.io/web-stories-wp/

@mohdsayed
Copy link
Member

mohdsayed commented May 17, 2021

We were able to fix the issue and I verified the markup with and without animation added on google ad manager's new creative, and it shows a valid AMP markup now! Though I do not know how to test it out in DV360

image

@mohdsayed mohdsayed self-assigned this May 17, 2021
@divyarajmasani divyarajmasani removed their assignment May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants