Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Considerations: autoloader, singleton #90

Open
divyarajmasani opened this issue Apr 2, 2024 · 0 comments
Open

Update Considerations: autoloader, singleton #90

divyarajmasani opened this issue Apr 2, 2024 · 0 comments
Assignees

Comments

@divyarajmasani
Copy link
Contributor

Summary

  1. Currently, 'blank-theme' uses a custom autoloader, which works fine. However, to align the code more with how things are done for PHP in general, we can update to use the composer autoloader and remove the custom one.

  2. Revisit the Singleton pattern used to compose and load the necessary components for the theme. Now, this may result in unnecessary classes being loaded on all requests. This may be fine with a small-scale code base; however, the complexity of features may add to memory cost. Identify/update to only load classes when needed.

References

Acceptance Criteria

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants