Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Naming things #101

Closed
rahul286 opened this issue Jan 19, 2024 · 1 comment · Fixed by #155
Closed

Naming things #101

rahul286 opened this issue Jan 19, 2024 · 1 comment · Fixed by #155
Labels
enhancement Feature Enhancement

Comments

@rahul286
Copy link
Member

rahul286 commented Jan 19, 2024

Let's solve #2 problem of Computer Science (source) :D

Everywhere we call the thing FM creates is site while the things that are within frappe bench are also called site

I think what FM creates is actually a bench. Unsure if I can fm shell <name> and create more benches within.

@Xieyt Xieyt added the enhancement Feature Enhancement label Mar 19, 2024
@Xieyt
Copy link
Collaborator

Xieyt commented Mar 19, 2024

You are correct this is indeed confusing. I will go with your suggestion and refactor code to follow the same.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature Enhancement
Projects
None yet
2 participants