Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Directory Organization #86

Closed
rubenssoto opened this issue Nov 3, 2020 · 5 comments · Fixed by #89
Closed

Directory Organization #86

rubenssoto opened this issue Nov 3, 2020 · 5 comments · Fixed by #89
Assignees
Labels
enhancement New feature or request python

Comments

@rubenssoto
Copy link

Today whale pull table information and organize in the same directory, so we have a mix of tables of different databases, I think that could be more organized if we have a directory for each database. It make senses for you?

Thank you!

@yosupmoon
Copy link
Contributor

Which ones would you like prioritized? e.g. Snowflake, BigQuery, AWS S3, etc. A comprehensive collection that would make you happy?

@rubenssoto
Copy link
Author

Hi Joseph, how are you?

I used only aws glue catalog, what do you mean with comprehensive collection?

@rsyi
Copy link
Owner

rsyi commented Nov 3, 2020

Yeah this makes sense, @rubenssoto. Just to be clear, I'll walk through how I'm thinking of changing this:

For one of my tables, the present format is:

glue/sample-client-pg-1.postgres_public_comments

which corresponds to

{name}/{instance}.{catalog}_{schema}_{table}

Is this what you'd want instead?

{name}/{instance}/{catalog}_{schema}_{table}

I.e. isolate the metadata based on instance name into different folders?

The only tricky thing is that this would affect the backwards compatibility of the documentation, so I'll have to build in a small migration script, but I think that's no big deal. :)

@rsyi rsyi self-assigned this Nov 3, 2020
@rsyi rsyi added enhancement New feature or request python labels Nov 3, 2020
@rubenssoto
Copy link
Author

Yeah, I think exactly this

{name}/{instance}/{catalog}{schema}{table}

Instance is the same as database right?

@rubenssoto
Copy link
Author

I don't need backward compatibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request python
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants