From 4dc67e7416cbf0eed4b537126c359b032381472f Mon Sep 17 00:00:00 2001 From: Carson Date: Wed, 26 May 2021 12:49:24 -0500 Subject: [PATCH] Leverage bslib::page_navbar()'s more intelligent title->windowTitle handling Closes #2310 --- R/bootstrap.R | 8 +++++--- man/navbarPage.Rd | 8 +++++--- 2 files changed, 10 insertions(+), 6 deletions(-) diff --git a/R/bootstrap.R b/R/bootstrap.R index c9bb21c8dc..da42cdee51 100644 --- a/R/bootstrap.R +++ b/R/bootstrap.R @@ -380,8 +380,10 @@ collapseSizes <- function(padding) { #' (useful for viewing on smaller touchscreen device) #' @param fluid `TRUE` to use a fluid layout. `FALSE` to use a fixed #' layout. -#' @param windowTitle The title that should be displayed by the browser window. -#' Useful if `title` is not a string. +#' @param windowTitle the browser window title (as a character string). The +#' default value, `NA`, means to use any character strings that appear in +#' `title` (if none are found, the host URL of the page is displayed by +#' default). #' @inheritParams bootstrapPage #' @param icon Optional icon to appear on a `navbarMenu` tab. #' @@ -425,7 +427,7 @@ navbarPage <- function(title, collapsible = FALSE, fluid = TRUE, theme = NULL, - windowTitle = title, + windowTitle = NA, lang = NULL) { bslib::navbar_page( ..., title = title, id = id, selected = selected, diff --git a/man/navbarPage.Rd b/man/navbarPage.Rd index 7bd8dde63f..25a9b00dce 100644 --- a/man/navbarPage.Rd +++ b/man/navbarPage.Rd @@ -17,7 +17,7 @@ navbarPage( collapsible = FALSE, fluid = TRUE, theme = NULL, - windowTitle = title, + windowTitle = NA, lang = NULL ) @@ -73,8 +73,10 @@ build of Bootstrap 3 with a customized version of Bootstrap 3 or higher. (normally a css file within the www directory, e.g. \code{www/bootstrap.css}). }} -\item{windowTitle}{The title that should be displayed by the browser window. -Useful if \code{title} is not a string.} +\item{windowTitle}{the browser window title (as a character string). The +default value, \code{NA}, means to use any character strings that appear in +\code{title} (if none are found, the host URL of the page is displayed by +default).} \item{lang}{ISO 639-1 language code for the HTML page, such as "en" or "ko". This will be used as the lang in the \code{} tag, as in \code{}.