Upgrade jQuery by using the R package jquerylib #2197
Merged
+2
−232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…urrently ships jquery 3.x by default
yihui
commented
Aug 6, 2021
cderv
reviewed
Aug 16, 2021
| version = "1.11.3", | ||
| src = pkg_file("rmd/h/jquery"), | ||
| script = "jquery.min.js") | ||
| jquerylib::jquery_core() |
There was a problem hiding this comment.
@yihui What about already pinning version 3 to prevent any undesired future change if/when jquerylib changes its default ?
-jquerylib::jquery_core()
+jquerylib::jquery_core(major_version = 3)There was a problem hiding this comment.
I guess jquerylib won't change the version here suddenly (Carson will probably notify us), but I can definitely see the value of being a little conservative by pinning the version. To make it easier for ourselves to test future versions of jQuery, we can use an option to specify the version and default it to 3, e.g.,
jquerylib::jquery_core(major_version = getOption('rmarkdown.jquery.version', 3))There was a problem hiding this comment.
Oh I like the option ! I don't have this habits but this is great to have some config flag around for us to use.
There was a problem hiding this comment.
I guess jquerylib won't change the version here suddenly (Carson will probably notify us), but I can definitely see the value of being a little conservative by pinning the version.
And yes I agree. I just see not harm and probably some benefit of being conservative for such things.
yihui
added a commit
that referenced
this pull request
Aug 16, 2021
jonathan-g
added a commit
to jonathan-g/rmarkdown
that referenced
this pull request
Aug 17, 2021
…dio-main * 'main' of https://github.com/rstudio/rmarkdown: pin the jquery version to 3: rstudio#2197 (comment)
jonathan-g
added a commit
to jonathan-g/rmarkdown
that referenced
this pull request
Aug 17, 2021
* rstudio-main: pin the jquery version to 3: rstudio#2197 (comment)
clrpackages
pushed a commit
to clearlinux-pkgs/R-rmarkdown
that referenced
this pull request
Sep 16, 2021
…n 2.11
Christophe Dervieux (2):
Mark result of citeproc conversion as UTF-8 (#2202)
Bump version
Garrick Aden-Buie (1):
Prerender shiny rmd in separate environment (#2203)
Yihui Xie (9):
start the next version
close #1814: upgrade jquery by using the R package jquerylib, which currently ships jquery 3.x by default (#2197)
pin the jquery version to 3: rstudio/rmarkdown#2197 (comment)
fix yihui/xaringan#331: respect relative paths in parent directories in the `css` argument of `html_document()`
use sass::output_template() instead of storing a copy in rmarkdown
export convert_ipynb() per suggestion of @acircleda
roxygenize and bump version
https://rmarkdown.rstudio.com/authoring_bibliographies_and_citations.html -> https://pandoc.org/MANUAL.html#citations
CRAN release v2.11
christophe dervieux (1):
Add a specific dirname for sass caching
jonathan-g
added a commit
to jonathan-g/rmarkdown
that referenced
this pull request
Sep 17, 2021
Merge branch 'jg-tree-fix' into jg-devel # By Yihui Xie (9) and others # Via Jonathan Gilligan (3) and Yihui Xie (1) * jg-tree-fix: import bslib (rstudio#2154) CRAN release v2.11 https://rmarkdown.rstudio.com/authoring_bibliographies_and_citations.html -> https://pandoc.org/MANUAL.html#citations Add a specific dirname for sass caching roxygenize and bump version export convert_ipynb() per suggestion of @acircleda use sass::output_template() instead of storing a copy in rmarkdown fix yihui/xaringan#331: respect relative paths in parent directories in the `css` argument of `html_document()` Bump version Prerender shiny rmd in separate environment (rstudio#2203) Mark result of citeproc conversion as UTF-8 (rstudio#2202) Fixed conflicts with rstudio main version. Update documentation for html_document. Add self (JG) as a contributor in DESCRIPTION. Resolve conflicts with new updates to RStudio main branch. pin the jquery version to 3: rstudio#2197 (comment) # Conflicts: # DESCRIPTION # NEWS.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #1814