Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix confusing message about "when reading a pin" for pin_write() #786

Closed
juliasilge opened this issue Sep 19, 2023 · 1 comment · Fixed by #787
Closed

Fix confusing message about "when reading a pin" for pin_write() #786

juliasilge opened this issue Sep 19, 2023 · 1 comment · Fixed by #787

Comments

@juliasilge
Copy link
Member

If you don't include the username when writing a pin to Connect, it gives a confusing message:

library(pins)
board <- board_connect()
#> Connecting to Posit Connect 2023.07.0 at <https://colorado.posit.co/rsc>
board |> pin_write(10:20, "nice-numbers", type = "json")
#> ! Please use full name when reading a pin: "julia.silge/nice-numbers", not "nice-numbers".
#> Writing to pin 'julia.silge/nice-numbers'

Created on 2023-09-18 with reprex v2.0.2

Notice:

when reading a pin

but we were writing! It happens in rsc_content_find(), which is used a lot and not only when reading. Probably should update this message:

cli::cli_alert_warning("Please use full name when reading a pin: {.val {name$full}}, not {.val {name$name}}.")

@github-actions
Copy link

This issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Oct 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant