Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redirects can break metadata lookups on Connect #759

Closed
colearendt opened this issue Jul 31, 2023 · 7 comments
Closed

Redirects can break metadata lookups on Connect #759

colearendt opened this issue Jul 31, 2023 · 7 comments

Comments

@colearendt
Copy link
Contributor

We recently migrated our internal Connect server to a new URL and set up a redirect from old -> new.

Pins mostly handles this OK, but returned some invalid metadata that generated error messages like:

Error: Can't find version '400657'

Basically, pin_versions() seemed to return an array of versions that was not necessarily associated with the pin in question

Slack thread with details: https://positpbc.slack.com/archives/C03DK5MJW6S/p1690668801613589?thread_ts=1690667853.301989&cid=C03DK5MJW6S

@jspiewak

@machow
Copy link
Collaborator

machow commented Jul 31, 2023

Is there any chance you could get the version of pins that produced this error?

(Another quick thought is that changing the server url fixed it, and that would also create a new cache. Though pretty stumped at the repeated version numbers!)

@jspiewak
Copy link
Member

See the Slack thread. I fetched the versions for several of the pins.

@machow
Copy link
Collaborator

machow commented Jul 31, 2023

Ah, sorry--that was bad phrasing on my part. I meant to say-- what was the version of the pins package you were using? 😅

@jspiewak
Copy link
Member

jspiewak commented Aug 1, 2023

Unfortunately not able to reproduce at the moment, and it is possible this was before updating to latest pins version (1.2.0).

@juliasilge
Copy link
Member

I'm definitely interested in any details that could help reproduce this! Seeing what you got from pin_versions() is pretty mystifying to me.

@juliasilge
Copy link
Member

Related to the problems that came up during our internal Connect server migration, we now have these merged in:

Still to do is deal with:

According to my notes from our small retro on the migration, I believe this is all we can currently reproduce so I'm going to close this issue about those bananas 🍌 problems with the metadata. Please feel free to reopen or make a new issue if we have something more to work with on problems we observed!

@github-actions
Copy link

This issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Sep 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants