From 02b94e8bdc856f75a50413e9f106e3cd161fc639 Mon Sep 17 00:00:00 2001 From: Carson Date: Thu, 18 Mar 2021 18:00:15 -0500 Subject: [PATCH] Provide a default method so as not to break existing code (I'm looking at you quillt:::thumbnails) --- NAMESPACE | 4 ++-- R/tags.R | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/NAMESPACE b/NAMESPACE index c6edf8ef..2e22e9e7 100644 --- a/NAMESPACE +++ b/NAMESPACE @@ -20,9 +20,9 @@ S3method(print,shiny.tag) S3method(print,shiny.tag.list) S3method(tagAppendAttributes,shiny.tag) S3method(tagAppendAttributes,shiny.tag.function) -S3method(tagAppendChild,shiny.tag) +S3method(tagAppendChild,default) S3method(tagAppendChild,shiny.tag.function) -S3method(tagAppendChildren,shiny.tag) +S3method(tagAppendChildren,default) S3method(tagAppendChildren,shiny.tag.function) S3method(tagSetChildren,shiny.tag) S3method(tagSetChildren,shiny.tag.function) diff --git a/R/tags.R b/R/tags.R index 4dbb2323..c92e577c 100644 --- a/R/tags.R +++ b/R/tags.R @@ -345,7 +345,7 @@ tagAppendChild <- function(tag, child) { } #' @export -tagAppendChild.shiny.tag <- function(tag, child) { +tagAppendChild.default <- function(tag, child) { tag$children[[length(tag$children) + 1]] <- child tag } @@ -368,7 +368,7 @@ tagAppendChildren <- function(tag, ..., list = NULL) { } #' @export -tagAppendChildren.shiny.tag <- function(tag, ..., list = NULL) { +tagAppendChildren.default <- function(tag, ..., list = NULL) { tag$children <- unname(c(tag$children, c(dots_list(...), list))) tag }