Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LaTeX table rendering issue with math + fmt_markdown() #1741

Closed
olivroy opened this issue Jul 3, 2024 · 5 comments
Closed

LaTeX table rendering issue with math + fmt_markdown() #1741

olivroy opened this issue Jul 3, 2024 · 5 comments
Assignees

Comments

@olivroy
Copy link
Collaborator

olivroy commented Jul 3, 2024

Invalid

I am trying to see what the problem is here

The example in https://quarto-gt-examples.netlify.app/gt-fmt_markdown.html doesn't render correctly.

Locally, I see this with latest dev

image

On gt 0.10.1 (on webR)
image

Locally, I see the warning

Avis : LaTeX-incompatible input and strict mode is set to 'warn': In LaTeX, \\ or \newline does nothing in display mode [newLineInDisplayMode]

Let me know if you need more information.

In Quarto 1.5

image

@olivroy
Copy link
Collaborator Author

olivroy commented Jul 3, 2024

Related to #1687

@olivroy olivroy closed this as not planned Won't fix, can't repro, duplicate, stale Jul 3, 2024
@olivroy olivroy reopened this Jul 3, 2024
@rich-iannone
Copy link
Member

This is entirely a problem of not faithfully extracting the examples from the Rd database to the Quarto documents for the site. I made a quick fix here: 0fb1c96. And if you copy that equation example into a Quarto doc and render it (or run it in the console), it renders without error.

Here's the zipped Quarto doc for testing:
formulas.qmd.zip

@rich-iannone
Copy link
Member

The file https://github.com/rstudio/gt/blob/master/R/utils_examples.R has all the Quarto-example-building logic. It needs some attention because of the above issue. Also, it only works for R4.2 and below since the .Rd database structure seems to have changed.

Once the examples are repaired (and the workflows run successfully again), it would be great to have LaTeX output tests done via Quarto (this is the near-term goal).

@olivroy
Copy link
Collaborator Author

olivroy commented Jul 3, 2024

Sure, I will take a look. Would you mind trying to add a CodeCov token, so that we can track coverage on codecov again. (The test-coverage action has been failing for a few weeks now) r-lib/actions#834

@rich-iannone
Copy link
Member

The CodeCov token has been added as CODECOV_TOKEN. Thanks for reminding me of that.

@olivroy olivroy closed this as completed Jul 3, 2024
@olivroy olivroy closed this as not planned Won't fix, can't repro, duplicate, stale Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants