Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full names not being respected in fa_i #68

Closed
neilhatfield opened this issue Oct 25, 2021 · 1 comment · Fixed by #77
Closed

Full names not being respected in fa_i #68

neilhatfield opened this issue Oct 25, 2021 · 1 comment · Fixed by #77

Comments

@neilhatfield
Copy link

Currently, full names of icons aren't being respected by the fa_i function. For example fa_i("far fa-sqaure") will get translated to <i class="fa fa-far fa-square"></i>. In essence, fa_i is prepending "fa" as the style and to the name, regardless of whether or not a full name is provided.

A solution would be examine whether the submitted name is a full name or shortened, potentially by checking whether there is a space in the name. If a full name is provided, then that should be used for the internal iconClass object rather than the paste0 output.

@rich-iannone
Copy link
Member

Thanks for reporting and for the recommendations on how to resolve this issue. We will get to a fix on this quite soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment