Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't change right margin with margin_right #53

Closed
aosmith16 opened this issue Apr 6, 2021 · 1 comment · Fixed by #54
Closed

Can't change right margin with margin_right #53

aosmith16 opened this issue Apr 6, 2021 · 1 comment · Fixed by #54

Comments

@aosmith16
Copy link

I noticed that all my icons were slightly pushed to the left with the newest version of fontawesome. I attempted to change this via the new margin_right argument and, well, nothing happened, no matter what value I used.

I delved a tiny bit into the code and as far as I can tell that argument is never used in within the fa() function. Instead the right margin is hard-coded at ".2em". Am I missing something?

@rich-iannone
Copy link
Member

This is my mistake, sorry that it broke your existing document. I'd like to fix by making margin_right functional, defaulting to the "auto" margin (essentially 0, same as before the update), and adding a margin_left argument (default of "auto"). Once this is fixed, a patch release of the package will sent to CRAN.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants