Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplify set_image_*() functions #294

Closed
toph-allen opened this issue Aug 30, 2024 · 0 comments · Fixed by #303
Closed

simplify set_image_*() functions #294

toph-allen opened this issue Aug 30, 2024 · 0 comments · Fixed by #303
Assignees

Comments

@toph-allen
Copy link
Collaborator

There are three functions to update content images:

  • set_image_path(content, path) uploads a local image file to Connect for use as a content image;
  • set_image_url(content, url) downloads an image from a URL and calls set_image_path();
  • set_image_webshot(content, ...) uses webshot2 to take a screenshot of the content, and calls set_image_path() with that resulting image.

The first function should just become set_content_image(content, path) or something similar. The other two should become recipes in the cookbook.

The tests for set_image_webshot() are very flaky, so they have been disabled in CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant