Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

httpuv should really be Suggests #1159

Closed
MichaelChirico opened this issue Dec 2, 2024 · 1 comment
Closed

httpuv should really be Suggests #1159

MichaelChirico opened this issue Dec 2, 2024 · 1 comment

Comments

@MichaelChirico
Copy link

{httpuv} was added here:

9fea1a7

That commit references

fa31cd2

There are still only two usages of {httpuv} in the {DT} sources:

DT/R/shiny.R

Lines 679 to 692 in def0cae

k = httpuv::decodeURIComponent(k)
column_opts = list(
regex = col[['search']][['regex']] != 'false',
caseInsensitive = global_opts$caseInsensitive
)
dj = data[i, j]
i = i[doColumnSearch(dj, k, options = column_opts)]
if (length(i) == 0) break
}
# global searching
if (length(i) && any((k <- q$search[['value']]) != '')) {
dg = data[i, searchable, drop = FALSE]
k = httpuv::decodeURIComponent(k)

They are both in R/shiny.R. Since {shiny} is itself Suggests, it makes sense to me that {httpuv} should be as well.

@yihui yihui closed this as completed in 14c33d9 Dec 2, 2024
@yihui
Copy link
Member

yihui commented Dec 2, 2024

You are right. Done. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants