Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove jQuery dependency #7

Closed
pnordahl opened this issue Aug 21, 2013 · 15 comments
Closed

Remove jQuery dependency #7

pnordahl opened this issue Aug 21, 2013 · 15 comments

Comments

@pnordahl
Copy link

What we're doing here shouldn't require a hard dependency on jQuery.

@mparramont
Copy link

I'm working on it, will submit a PR as soon as I'm done:
Repo
More info

@rstacruz
Copy link
Owner

Nice.

Personally, I was hesitant to do this from the start because you'd have to implement the following things on your own:

  • Auto-detection of vendor prefixes
  • Animation queueing

Not sure how much kb that'd take, but let's see. Nice work mparramont!

@mparramont
Copy link

The test suite is being of great help already, good job there @rstacruz!
Will keep you updated :)

@jcuervo
Copy link

jcuervo commented Aug 21, 2013

+1

@LeonMelis
Copy link

Looks to me jQuery is only used for $.extend() ??

@Mithgol
Copy link
Contributor

Mithgol commented Aug 21, 2013

jQuery is also used in NProgress.render, and a jQuery instance is returned from it as $progress.

You may see several jQuery methods of $progress used later, such as .find or .css.

@rahulcs
Copy link
Contributor

rahulcs commented Aug 21, 2013

if you closely look at the code, nprogress.js uses $.extend(), $.find(), addClass(), removeClass(), appendTo() & html() functions.

@caarlos0
Copy link

Not that hard to remove, I believe...

@JonDum
Copy link

JonDum commented Aug 21, 2013

+1 for jQuery independence.

@victorb
Copy link

victorb commented Aug 21, 2013

There is two other solutions. One is a Angular provider I made myself[1] and the other one is a vanilla Javascript solution[2]

[1] http://victorbjelkholm.github.io/ngProgress/
[2] http://buunguyen.github.io/rainbow.js/

@rcstr
Copy link

rcstr commented Aug 23, 2013

thanks @victorbjelkholm

@rferri
Copy link
Contributor

rferri commented Aug 28, 2013

I've got a branch without jQuery working here. I'd be happy to submit a pull request if there hasn't been any major progress yet. The css helper should also address #17.

@mparramont
Copy link

I just checked it out and all the tests are green for me. Great job!

@esteinborn
Copy link

+1

@rstacruz
Copy link
Owner

👍!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests