-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove jQuery dependency #7
Comments
Nice. Personally, I was hesitant to do this from the start because you'd have to implement the following things on your own:
Not sure how much kb that'd take, but let's see. Nice work mparramont! |
The test suite is being of great help already, good job there @rstacruz! |
+1 |
Looks to me jQuery is only used for $.extend() ?? |
jQuery is also used in You may see several jQuery methods of |
if you closely look at the code, nprogress.js uses |
Not that hard to remove, I believe... |
+1 for jQuery independence. |
There is two other solutions. One is a Angular provider I made myself[1] and the other one is a vanilla Javascript solution[2] [1] http://victorbjelkholm.github.io/ngProgress/ |
thanks @victorbjelkholm |
I just checked it out and all the tests are green for me. Great job! |
+1 |
👍! |
What we're doing here shouldn't require a hard dependency on jQuery.
The text was updated successfully, but these errors were encountered: