add price arrows #184
add price arrows #184
Conversation
|
If you could extract just the price arrows portion of this pr we could get it tested and merged while we wait for the discordgo pr. |
There was a problem hiding this comment.
You need to update all database references to account for the new attribute.
You can see all those references in this file: https://github.com/rssnyder/discord-stock-ticker/blob/master/floor_request.go
You also need to account for creating the new row when a user uses a database from a previous version that does not have this feature: https://github.com/rssnyder/discord-stock-ticker/blob/master/manager.go#L396-L420
I will. Do you want me to merge each new feature individually PRs or do you want me to bundle them as one big PR? |
This commit adds the `color` argument to the floor ticker.
rickstaa
force-pushed
the
add_price_arrows
branch
from
b075565
to
e7c9731
Compare
This commit uses the new UpdateWatchStatus of bwmarrin/discordgo#1291 to set the activity to watching instead of streaming.
This commit adds the `activity` argument to the floor ticker.
This commit adds the `colors` argument to the floor ticker.
rickstaa
force-pushed
the
add_price_arrows
branch
10 times, most recently
from
d468491
to
c6047dc
Compare
This commit adds the `decorator` argument to the floor ticker.
This commit makes sure people can disable the price arrows by setting the `decorator` argument to `" "`.
rickstaa
force-pushed
the
add_price_arrows
branch
from
c6047dc
to
225aa2f
Compare
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
Also not stale. |
This commit makes sure the decorator is applied.
|
@rssnyder Updated to the latest master! Think we are good to go now 👍🏻. |
|
@rickstaa wana rebase and ill check this out? |
Amazing! I merged instead since rebase gave me to many conflicts. Let me know what you think. |
|
@rssnyder, no pressure, but I was wondering if the PR is good to go or if I still need to change something. 🫡 |
Co-authored-by: Riley Snyder <[email protected]>
Co-authored-by: Riley Snyder <[email protected]>
Co-authored-by: Riley Snyder <[email protected]>
This PR adds the
arrowsoption to the floor ticker. This option can be used to display price direction arrows with the price. Follows up on #183.