-
-
Notifications
You must be signed in to change notification settings - Fork 396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RSpec raises OutOfMemoryError #166
Comments
The problem is that I think it's due to
Since 044b0a6, we end up calling something like @dchelimsky, I'm not totally sure what |
Yah, interesting:
|
It's to remain compatible with custom matchers which might still return an array from |
The way |
Do you think it's our responsibility to do anything? Or is this a |
I'm not ready to point fingers until I see where it's happening, but it sounds like something in the execution path is not playing nice with |
Could also be a |
|
Even without RSpec involved, a
|
And viola! Closing this. @markburns, @alindeman either of you want to report this to https://github.com/rack/rack/issues? |
Happy to raise it there tbh I wasn't sure of the cause or where to report but did my best. Wasn't sure where the 'blame' might lay but thought it may be the to_ary/finish aliasing. Ok hopefully can solve it. And for anyone stumbling across this problem the solution in this case is to not compare with last_response but to compare with last_response.body Sent from my iPhone On 21 Aug 2012, at 23:53, David Chelimsky [email protected] wrote:
|
I went ahead and raised the issue in rack rack/rack#419 because this same issue came up in rspec-rails' tracker rspec/rspec-rails#601. |
Thanks @dchelimsky sorry, didn't get chance to raise this over there. :-) |
No worries @markburns. |
Running in the debugger it seems to occur somewhere after fail_with_message
rspec-expectations-2.11.2/lib/rspec/matchers/operator_matcher.rb:70
then into
rspec-expectations-2.11.2/lib/rspec/expectations/fail_with.rb:22
during the check for all_strings
shutl_neo4j/gems/rspec-expectations-2.11.2/lib/rspec/expectations/fail_with.rb:43
this line:
we end up in a loop inside
rack-1.4.1/lib/rack/response.rb:72
finish method
seems to be related to the aliasing of to_ary
gist to replicate available at
https://gist.github.com/3414935
The text was updated successfully, but these errors were encountered: