Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn if with_them is used before where is defined #9

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Warn if with_them is used before where is defined #9

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions lib/rspec/parameterized/core.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,8 @@ def with_them(*args, &b)
@parameter ||= nil

if @parameter.nil?
warn "#{b&.source_location&.join(':') || caller[0]}: `where` not defined."
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if with_them makes sense to be called without a block 🤷

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to add specs once the concept is accepted.


@parameterized_pending_cases ||= []
@parameterized_pending_cases << [args, b]
else
Expand Down