Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporary workaround for Vanilla HTML projects? #131

Closed
binarykitchen opened this issue Oct 2, 2024 · 4 comments · Fixed by #133
Closed

Temporary workaround for Vanilla HTML projects? #131

binarykitchen opened this issue Oct 2, 2024 · 4 comments · Fixed by #133

Comments

@binarykitchen
Copy link

I understand, Vanilla HTML support is scheduled for later in your Roadmap.

But I need it now :)

So, wondering if there is a hack or workaround to run it on Vanilla HTML using the storybook-builder-rsbuild package alone?

@binarykitchen
Copy link
Author

Nice, thank you @fi3ework I'll check it out asap

@binarykitchen
Copy link
Author

Most works very well. One little feedback @fi3ework

name: getAbsolutePath('storybook-html-rsbuild'),

That function getAbsolutePath isn't needed, it works without.

Then I would point it to the rsbuild configuration like that for example:

  framework: {
    name: "storybook-html-rsbuild",
    options: {
      builder: {
        rsbuildConfigPath: "etc/rsbuild/config.ts",
      },
    },
  },

@fi3ework
Copy link
Member

fi3ework commented Oct 3, 2024

That function getAbsolutePath isn't needed, it works without.

It's necessary only when no hoist is allowed.

@binarykitchen
Copy link
Author

I see.

Add to documentation maybe?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants