Break a retain cycle #444
Merged
Break a retain cycle #444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thank you! |
rs
pushed a commit
that referenced
this pull request
Aug 9, 2013
RoCry
pushed a commit
to RoCry/SDWebImage
that referenced
this pull request
Aug 14, 2013
hsoi
pushed a commit
to barz/SDWebImage
that referenced
this pull request
Dec 20, 2013
…work, which you can trace via the github issues (e.g. SDWebImage#466) seem to have brought about better solutions. Somehow tho, my fix remained in our branch. I recently diff’d our ‘barz-master’ branch vs the ‘rs:master’ and while a few things are kosher to keep, this should go to maintain closer parity with the upstream/master.
devedup
pushed a commit
to FilmFlexMovies/SDWebImage
that referenced
this pull request
Sep 10, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking a retain cycle that seems to be at the root of some table scrolling lockup problems. See #425