connectionDidFinishLoading

[TaoXiaoSeng]

i see the code like this
1:

• (void)connectionDidFinishLoading:(NSURLConnection *)aConnection {
  SDWebImageDownloaderCompletedBlock completionBlock = self.completedBlock;
  @synchronized(self) {
  CFRunLoopStop(CFRunLoopGetCurrent());
  self.thread = nil;
  self.connection = nil;
  [[NSNotificationCenter defaultCenter] postNotificationName:SDWebImageDownloadStopNotification object:nil];
  }
  ......

2:

• (void)connection:(NSURLConnection *)connection didFailWithError:(NSError *)error {
  CFRunLoopStop(CFRunLoopGetCurrent());
  [[NSNotificationCenter defaultCenter] postNotificationName:SDWebImageDownloadStopNotification object:nil];

  if (self.completedBlock) {
  self.completedBlock(nil, nil, error, YES);
  }
  .....

this two functions are the delegate callback for NSURLConnection normally.
but in sdwebimage, it only do some special operations in connectionDidFinishLoading.

@synchronized(self) {
CFRunLoopStop(CFRunLoopGetCurrent());
self.thread = nil;
self.connection = nil;
[[NSNotificationCenter defaultCenter] postNotificationName:SDWebImageDownloadStopNotification object:nil];
}

i think this code is used to race conditions with cancel operation. is it true?
If so, why this code only write in connectionDidFinishLoading, what about the function - (void)connection:(NSURLConnection *)connection didFailWithError:(NSError *)error ?

i hope you could tell me the reason. thanks very much!

[bpoplauschi]

@TaoXiaoSeng thanks for noticing this, indeed both functions have to have the same behavior

[TaoXiaoSeng]

OK, just like i thought before