Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable tests with Ubuntu 22.04 #181

Merged
merged 1 commit into from
Dec 5, 2023

Conversation

joanhey
Copy link
Contributor

@joanhey joanhey commented Dec 5, 2023

It is working OK with Ubuntu 22.04, but fail the tests.

Till we fix the tests, will be disabled, but we can merge in the main branch.

Only test Unbuntu 22.04, Nginx 1.25.3 and PHP 8.3 in the dev branch for now.

@rryqszq4
Copy link
Owner

rryqszq4 commented Dec 5, 2023

Just fixd request body larger than 10kb.
42fb4ff

@joanhey
Copy link
Contributor Author

joanhey commented Dec 5, 2023

@joanhey
Copy link
Contributor Author

joanhey commented Dec 5, 2023

After merge in master, and create a new release, you can close issues:

And check other issues, if we can close them.

@rryqszq4
Copy link
Owner

rryqszq4 commented Dec 5, 2023

After merge in master, and create a new release, you can close issues:

And check other issues, if we can close them.

OK, I want to ready merge this request.

@rryqszq4 rryqszq4 merged commit 3e167b9 into rryqszq4:development Dec 5, 2023
56 of 57 checks passed
@joanhey joanhey deleted the disable-tests-22.04 branch December 5, 2023 12:12
@joanhey joanhey restored the disable-tests-22.04 branch December 5, 2023 12:14
@joanhey joanhey deleted the disable-tests-22.04 branch December 5, 2023 12:14
@rryqszq4
Copy link
Owner

rryqszq4 commented Dec 5, 2023

@joanhey
Copy link
Contributor Author

joanhey commented Dec 5, 2023

Yes, but this test only run in the dev branch, not in the others branches.
When we fix tests with Ubuntu 22.04, they will be added to the other branches.

@joanhey
Copy link
Contributor Author

joanhey commented Dec 5, 2023

@rryqszq4
Copy link
Owner

rryqszq4 commented Dec 5, 2023

Yes, but this test only run in the dev branch, not in the others branches. When we fix tests with Ubuntu 22.04, they will be added to the other branches.

I understand.

@joanhey
Copy link
Contributor Author

joanhey commented Dec 5, 2023

And I'm creating pestPHP test to use in any PHP runtime.
I created it for my project Adapterman, but now I'm separating to use it alone.

Later I'll add to ngx-php.
So we will have another test, using PHP.

With Adapterman:
https://github.com/joanhey/AdapterMan/actions/runs/6202720452/job/16842037726#step:5:133

The repo for the stand alone is in progress in https://github.com/joanhey/TestMan
So the same tests, can be run in any php runtime.
Now every runtime create its own tests.
And it will be easier have feedback from other runtimes, as one issue in one can affect another runtimes.

And also started a new repo ngx-adapter, it's an Adapterman version for use with ngx-php.
To use any php fw or app that use front-controller with ngx-php, without touch 1 line of code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants