From 7b2d37e2ee2eff39798a6a5e960165c4c0284be2 Mon Sep 17 00:00:00 2001 From: Alexey Babik Date: Thu, 4 Jan 2024 14:01:16 -0600 Subject: [PATCH 1/4] Use maskInputFn for full snapshot --- packages/rrweb-snapshot/src/snapshot.ts | 2 +- packages/rrweb/src/record/index.ts | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/packages/rrweb-snapshot/src/snapshot.ts b/packages/rrweb-snapshot/src/snapshot.ts index 301f84430e..0b59f18c36 100644 --- a/packages/rrweb-snapshot/src/snapshot.ts +++ b/packages/rrweb-snapshot/src/snapshot.ts @@ -1235,7 +1235,7 @@ function snapshot( inlineStylesheet?: boolean; maskAllInputs?: boolean | MaskInputOptions; maskTextFn?: MaskTextFn; - maskInputFn?: MaskTextFn; + maskInputFn?: MaskInputFn; slimDOM?: 'all' | boolean | SlimDOMOptions; dataURLOptions?: DataURLOptions; inlineImages?: boolean; diff --git a/packages/rrweb/src/record/index.ts b/packages/rrweb/src/record/index.ts index 3b4475cfc9..64e1ad9f86 100644 --- a/packages/rrweb/src/record/index.ts +++ b/packages/rrweb/src/record/index.ts @@ -376,6 +376,7 @@ function record( inlineStylesheet, maskAllInputs: maskInputOptions, maskTextFn, + maskInputFn, slimDOM: slimDOMOptions, dataURLOptions, recordCanvas, From 70c340995f70326b3d8333a3d64e93528460e905 Mon Sep 17 00:00:00 2001 From: Justin Halsall Date: Fri, 5 Jan 2024 12:23:44 +0100 Subject: [PATCH 2/4] Create beige-olives-roll.md --- .changeset/beige-olives-roll.md | 7 +++++++ 1 file changed, 7 insertions(+) create mode 100644 .changeset/beige-olives-roll.md diff --git a/.changeset/beige-olives-roll.md b/.changeset/beige-olives-roll.md new file mode 100644 index 0000000000..eecb0e693d --- /dev/null +++ b/.changeset/beige-olives-roll.md @@ -0,0 +1,7 @@ +--- +"rrweb-snapshot": patch +"rrweb": patch +--- + +Fix maskInputFn is ignored during the creation of the full snapshot +Fix maskInputFn type in `snapshot` From aca1846450311abb99615c78e6625d6ef508635b Mon Sep 17 00:00:00 2001 From: Eoghan Murray Date: Thu, 6 Jun 2024 23:38:29 +0100 Subject: [PATCH 3/4] Update beige-olives-roll.md --- .changeset/beige-olives-roll.md | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.changeset/beige-olives-roll.md b/.changeset/beige-olives-roll.md index eecb0e693d..4707f55aca 100644 --- a/.changeset/beige-olives-roll.md +++ b/.changeset/beige-olives-roll.md @@ -3,5 +3,4 @@ "rrweb": patch --- -Fix maskInputFn is ignored during the creation of the full snapshot -Fix maskInputFn type in `snapshot` +Fix that the optional `maskInputFn` was being accidentally ignored during the creation of the full snapshot From c44b56c45ff35f21b312d5122c36c07d68b385d5 Mon Sep 17 00:00:00 2001 From: Eoghan Murray Date: Mon, 10 Jun 2024 10:50:31 +0100 Subject: [PATCH 4/4] Update beige-olives-roll.md prettier was complaining about the trailing space