Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Textarea shows default value twice in replay #1301

Closed
1 task done
josephmathew900 opened this issue Sep 9, 2023 · 7 comments
Closed
1 task done

[Bug]: Textarea shows default value twice in replay #1301

josephmathew900 opened this issue Sep 9, 2023 · 7 comments
Labels
bug Something isn't working

Comments

@josephmathew900
Copy link

josephmathew900 commented Sep 9, 2023

Preflight Checklist

  • I have searched the issue tracker for a bug report that matches the one I want to file, without success.

What package is this bug report for?

rrweb

Version

latest

Expected Behavior

Textarea shows default value twice in replay

Actual Behavior

Textarea default value should not be duplicated.

Steps to Reproduce

https://vimeo.com/862640906/5ee922b408

Testcase Gist URL

No response

Additional Information

I found a similar issue #745, and in that issue, it is mentioned that the bug has been fixed, but the issue still exists.

@josephmathew900 josephmathew900 added the bug Something isn't working label Sep 9, 2023
@YanJie-001
Copy link

I also encountered this bug and I didn't find that this bug was fixed.

@YanJie-001
Copy link

YanJie-001 commented Oct 13, 2023

This problem still exists. You can use rrweb-player and remember not to use the default version.To use 2.0.0-alpha.11.
@josephmathew900

@eoghanmurray
Copy link
Contributor

Thank you for putting together a great bug report.
In your video at 01:15 there is a screenshot of an event.
Is the textare node there part of a FullSnapshot or of a Mutation?

It seems to me that we should be addressing the problem on the record side, in that we shouldn't be producing textarea nodes which contain both a value attribute and a child with the same value in it. Would it be possible to look into that, and then see whether your fix in #1326 is still needed?

@eoghanmurray
Copy link
Contributor

eoghanmurray commented Oct 13, 2023

I'm just checking in case the record side can produce all variants of textareas:

  • attribute value and child text node set (as you witnessed)
  • only attribute value set
  • only child text node set
    If that is the case, then #1326 might break one of the latter two above

@josephmathew900
Copy link
Author

josephmathew900 commented Oct 19, 2023

@eoghanmurray

In your video at 01:15 there is a screenshot of an event.
Is the textare node there part of a FullSnapshot or of a Mutation?

The textarea node shown in the video is part of a FullSnapshot event.

@eoghanmurray
Copy link
Contributor

#1351 is ready for review; you can execute the code to check that it fixes your use case and let me know if not

@josephmathew900
Copy link
Author

I tested my use case with the code changes, and it is working perfectly fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants