-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: Textarea shows default value twice in replay #1301
Comments
I also encountered this bug and I didn't find that this bug was fixed. |
This problem still exists. You can use rrweb-player and remember not to use the default version.To use 2.0.0-alpha.11. |
Thank you for putting together a great bug report. It seems to me that we should be addressing the problem on the record side, in that we shouldn't be producing textarea nodes which contain both a value attribute and a child with the same value in it. Would it be possible to look into that, and then see whether your fix in #1326 is still needed? |
I'm just checking in case the record side can produce all variants of textareas:
|
The textarea node shown in the video is part of a FullSnapshot event. |
#1351 is ready for review; you can execute the code to check that it fixes your use case and let me know if not |
I tested my use case with the code changes, and it is working perfectly fine. |
Preflight Checklist
What package is this bug report for?
rrweb
Version
latest
Expected Behavior
Textarea shows default value twice in replay
Actual Behavior
Textarea default value should not be duplicated.
Steps to Reproduce
https://vimeo.com/862640906/5ee922b408
Testcase Gist URL
No response
Additional Information
I found a similar issue #745, and in that issue, it is mentioned that the bug has been fixed, but the issue still exists.
The text was updated successfully, but these errors were encountered: