Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Replay is not smooth #1144

Closed
1 task done
skodafir opened this issue Feb 17, 2023 · 3 comments
Closed
1 task done

[Bug]: Replay is not smooth #1144

skodafir opened this issue Feb 17, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@skodafir
Copy link

Preflight Checklist

  • I have searched the issue tracker for a bug report that matches the one I want to file, without success.

What package is this bug report for?

rrweb

Version

v2.0.0-alpha.5

Expected Behavior

The recorded sessions must play smoothly.

Actual Behavior

The replay is not smooth/responsive. Is it something you can fix? Is it related to the rrweb-player or the recorded sessions itself, and how can we improve it so it can play like a video?
Sometimes the replay stops working even if the player is not paused.

Steps to Reproduce

Try the demo on rrweb.io, the replay is not smooth.

Testcase Gist URL

No response

Additional Information

No response

@skodafir skodafir added the bug Something isn't working label Feb 17, 2023
@skodafir skodafir changed the title [Bug]: [Bug]: Replay is not smooth Feb 17, 2023
@YunFeng0817
Copy link
Member

Could you please provide a video to show how the replayer is not smooth?

@snopcoff
Copy link

snopcoff commented Feb 22, 2023

Hello @YunFeng0817
I am facing similar issue.

  1. On speed 1x, 2x, 4x the replay is smooth. (Expected)
  2. On speed 8x, the replay stopped in the middle of the session. (Expected: the replay should continue to the end of session)
  3. On speed 1x, 2x, 4x, 8x, when jumping to a time, the replay also stopped. (Expected: the replay should continue to the end of session)

Events data:

record_events.zip

Replay video:

video1712891573.zip

Record code:

rrweb.record({ emit(event) { events.push({ ...event, recordTime: moment().format("yyyy-MM-DD HH:mm:ss.SSSZZ") }); }, packFn: rrweb.pack, sampling: { mousemove: true, mouseInteraction: { MouseUp: false, MouseDown: false, Click: true, ContextMenu: true, DblClick: true, Focus: false, Blur: false, TouchStart: false, TouchEnd: false, }, scroll: 150, media: 600, input: 'all', }, });

Replay code:

setReplayer(new rrwebPlayer({ target: document.getElementById('replay-wrapper'), props: { events: events, showController: true, autoPlay: false, mouseTail: true, skipInactive: false, unpackFn: rrwebPlayer.unpackFn, useVirtualDom: true }, }));

Error log:

image

@YunFeng0817
Copy link
Member

YunFeng0817 commented Feb 22, 2023

Hello @YunFeng0817 I am facing similar issue.

  1. On speed 1x, 2x, 4x the replay is smooth. (Expected)
  2. On speed 8x, the replay stopped in the middle of the session. (Expected: the replay should continue to the end of session)
  3. On speed 1x, 2x, 4x, 8x, when jumping to a time, the replay also stopped. (Expected: the replay should continue to the end of session)

Events data:

record_events.zip

Replay video:

video1712891573.zip

Record code:

rrweb.record({ emit(event) { events.push({ ...event, recordTime: moment().format("yyyy-MM-DD HH:mm:ss.SSSZZ") }); }, packFn: rrweb.pack, sampling: { mousemove: true, mouseInteraction: { MouseUp: false, MouseDown: false, Click: true, ContextMenu: true, DblClick: true, Focus: false, Blur: false, TouchStart: false, TouchEnd: false, }, scroll: 150, media: 600, input: 'all', }, });

Replay code:

setReplayer(new rrwebPlayer({ target: document.getElementById('replay-wrapper'), props: { events: events, showController: true, autoPlay: false, mouseTail: true, skipInactive: false, unpackFn: rrwebPlayer.unpackFn, useVirtualDom: true }, }));

Error log:

image

I think this pull request can fix your errors.
#1139

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants