You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
The order of the dispose method is wrong.
Now, it first disposes the object and afterwards tries to remove the listeners, which doesn't make sense since it is already disposed. A package I use also throws an error if you execute code after disposing, which does make sense.
Flutter specification on state dispose is relevant here: Implementations of this method should end with a call to the inherited method, as in super.dispose().
I would strongly recommend adding this to the documentation and handling it the same.
Describe the bug
The order of the dispose method is wrong.
Now, it first disposes the object and afterwards tries to remove the listeners, which doesn't make sense since it is already disposed. A package I use also throws an error if you execute code after disposing, which does make sense.
Flutter specification on state dispose is relevant here: Implementations of this method should end with a call to the inherited method, as in super.dispose().
I would strongly recommend adding this to the documentation and handling it the same.
In short this:
should become this:
The text was updated successfully, but these errors were encountered: