Check the returned value of self.get_context() before unwrap it. #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rrevenantt
reviewed
Jan 13, 2022
| @@ -30,6 +30,10 @@ impl Eq for ATNConfig {} | |||
|
|
|||
| impl PartialEq for ATNConfig { | |||
| fn eq(&self, other: &Self) -> bool { | |||
| if self.get_context().is_none() || other.get_context().is_none() { | |||
There was a problem hiding this comment.
This will return false if both of them are None which is wrong.
Since i was writing that code, <Arc as PartialEq>::eq has been optimized with pointer comparison inside std itself, so better solution would be to replace whole Arc::ptr_eq stuff with direct comparison of self.contexts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as for other.get_context()