Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question about the normalized coordinates and img_aug #1

Open
Bear-kai opened this issue Mar 7, 2023 · 2 comments
Open

Question about the normalized coordinates and img_aug #1

Bear-kai opened this issue Mar 7, 2023 · 2 comments

Comments

@Bear-kai
Copy link

Bear-kai commented Mar 7, 2023

  • Q1: In the data loader func where makes the ground truth kp_uv link1, coordinate (-1,-1) corresponds to the left-bottom bbox corner.
    However, in the mesh_grid func which is used for the predicted kp_uv link2, coordinate (-1,-1) corresponds to the right-upper bbox corner.
    I think they should use the same "starting point", either left-bottom, or right-upper. Do I understand correctly?

  • Q2: I found the bboxes may have negative values, and (x1,y1) can be larger than (x2,y2) due to the possible 180 degree rotation in "NpScaleAndRotate". This will cause undesirable behaviour in the "torchvision.ops.roi_align" process ?! At least I have found the cropped image might be like the meaningless one below. Then I doubt is it suitable to do such augmentation?
    ttmmpp_im2_1

@Bear-kai Bear-kai changed the title Question about the normalized coordinates Question about the normalized coordinates and img_aug Mar 7, 2023
@nmerrill67
Copy link
Collaborator

I agree that I never liked the normalized coordinates moving the origin out of the top left. It was just a trick I borrowed from the old KeyPointNet repo, and it could probably be fixed easily (I only use that property when transforming from normalized to unnormalized or v.v.). I only manually tuned the augmentations a bit and did not guarantee that the object will always be visible I guess.

@Bear-kai
Copy link
Author

@nmerrill67 Hi, thanks for your reply. I have another question and expect your help.
I noticed that the evaluation results are based on a final global BA optimization here. Then, the frames can utilize info from the future. It confuses me cause I think in slam mode, we can only use info of the current frame and from history, not from the future!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants