Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Requires.private in the pkg-config metadata #36

Closed
nwalfield opened this issue Mar 24, 2023 · 2 comments
Closed

Requires.private in the pkg-config metadata #36

nwalfield opened this issue Mar 24, 2023 · 2 comments

Comments

@nwalfield
Copy link
Collaborator

nwalfield commented Mar 24, 2023

There's also the Requires.private in the pkg-config metadata, which is currently hardcoded to nettle. I'm about to submit a PR to the Fedora rust-rpm-sequoia package with both this patch, and one to just hard-replace nettle with openssl for their builds... but it'd be cool if there was some easy way to autoconfigure that from build.rs as well.

Originally posted by @ferdnyc in #35 (comment)

@ferdnyc
Copy link
Contributor

ferdnyc commented Mar 24, 2023

Heh. Even split off, this is kind of two things. (Bad habit of mine, sorry.)

@nwalfield
Copy link
Collaborator Author

There's also the Requires.private in the pkg-config metadata, which is currently hardcoded to nettle. I'm about to submit a PR to the Fedora rust-rpm-sequoia package with both this patch, and one to just hard-replace nettle with openssl for their builds... but it'd be cool if there was some easy way to autoconfigure that from build.rs as well.

Good point. I overlooked that. The backend is behind a feature gate (sequoia-openpgp/crypto-nettle, sequoia-openpgp/crypto-openssl, etc.) It would be worth investigating if we could use those to determine how to rewrite that file. Do you want to do that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants