Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove reset() from the API of objects where creating a new instance is sufficient #1718

Open
jan-kolarik opened this issue Sep 20, 2024 · 0 comments
Labels
ABI break API question Question about DNF 5 API usage Priority: LOW RFE Request For Enhancement (as opposed to a bug) Triaged Someone on the DNF 5 team has read the issue and determined the next steps to take

Comments

@jan-kolarik
Copy link
Member

This is a follow-up to #1678.

The goal is to review our reset() methods and identify those that provide no additional value compared to simply using the constructor. In these cases, I suggest dropping the reset() methods, as they require maintaining lists of objects (like vectors, maps, etc.) and their clearing can be handled automatically by the destructor.

@ppisar ppisar added RFE Request For Enhancement (as opposed to a bug) Priority: LOW Triaged Someone on the DNF 5 team has read the issue and determined the next steps to take ABI break API question Question about DNF 5 API usage labels Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ABI break API question Question about DNF 5 API usage Priority: LOW RFE Request For Enhancement (as opposed to a bug) Triaged Someone on the DNF 5 team has read the issue and determined the next steps to take
Projects
Status: Backlog
Development

No branches or pull requests

2 participants