Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing of running make_rpm.sh #436

Closed
InHavk opened this issue Sep 23, 2024 · 1 comment
Closed

Failing of running make_rpm.sh #436

InHavk opened this issue Sep 23, 2024 · 1 comment
Labels
Triaged Someone on the DNF team has read the issue and determined the next steps to take

Comments

@InHavk
Copy link
Contributor

InHavk commented Sep 23, 2024

Hello,
I tried to build rpm for actual release (1.1.4) via utils/make_rpm.sh and got some problems with it:

  • utils/make_rpm.sh ignores reference argument
  • spec file try to find tar.gz, but make_tarball generate tag.xz
  • make_tarball don't append revision in directory name, which is required for spec

OS: Almalinux 9.4

I made fixes (will attach PR after), but i'm not sure that it isn't broke any other scenarios. So, I'm ready to discussion.

@InHavk
Copy link
Contributor Author

InHavk commented Sep 25, 2024

remake it a little bit: instead of adding version to directory name, set spec to ignore that

@kontura kontura added the Triaged Someone on the DNF team has read the issue and determined the next steps to take label Oct 3, 2024
@InHavk InHavk closed this as completed Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Triaged Someone on the DNF team has read the issue and determined the next steps to take
Projects
None yet
Development

No branches or pull requests

2 participants