Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tus not handling correctly sendOnCreate with file smaller than chunk #779

Merged
merged 1 commit into from
Nov 10, 2024

Conversation

yoavniran
Copy link
Collaborator

in case the file uploaded is smaller than chunk when using sendOnCreate, the first request is the only request needed. no need to follow it up

fix for #759

…hunk

in case the file uploaded is smaller than chunk when using sendOnCreate, the first request
is the only request needed. no need to follow it up
Copy link
Contributor

github-actions bot commented Nov 10, 2024

📦 Bundle Size Report

namesizemaxsuccess
core10.55KB11.72KB🟢
ui-core-chunked15.91KB17.09KB🟢
ui-core13.52KB14.65KB🟢
all23.17KB23.44KB🟢

Copy link
Contributor

Coverage Report

Status Category Percentage Covered / Total
🟢 Lines 100% (🎯 99%) 1055 / 1055
🟢 Statements 100% (🎯 99%) 1091 / 1091
🟢 Functions 100% (🎯 100%) 315 / 315
🟢 Branches 98.91% (🎯 98%) 545 / 551
File CoverageNo changed files found.
Generated in workflow #219 for commit 09d38a2 by the Vitest Coverage Report Action

@yoavniran yoavniran merged commit 95131bc into master Nov 10, 2024
11 checks passed
@yoavniran yoavniran deleted the tus-error-file-size-small-than-chunk-dataOnCreate branch November 10, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant