Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embassy-RP and RP2040-hal Compatibility??? - Embedded_Hal::PWM:SetDutyCycle Assistance #816

Open
Token-Thinker opened this issue Jul 15, 2024 · 4 comments

Comments

@Token-Thinker
Copy link

Hello All,

I'm building a project based on embedded-hal and embassy for various boards that does async operations.
When doing research I noticed that the embassy-rp crate doesn't expose the channel functionality for setting the duty cycle using embedded-hal.

However rp2040-hal does expose that feature, but doesn't seem to have any ties to embassy, which leads to my issue/question.

Will rp2040-hal work with embassy and are there any potential plans on merging the two?

@9names
Copy link
Member

9names commented Jul 15, 2024

Will rp2040-hal work with embassy

No. Don't mix HALs.

are there any potential plans on merging the two?

No. These projects are never going to merge. Feel free to copy the implementation from rp2040-hal over to embassy-rp

@ithinuel
Copy link
Member

No. These projects are never going to merge. Feel free to copy the implementation from rp2040-hal over to embassy-rp

But be mindful of licences & a little attribution note wouldn't hurt either.

@Token-Thinker
Copy link
Author

What do you recommend than for async functionality when using rp-hal?

@ithinuel
Copy link
Member

ithinuel commented Jul 24, 2024

I'd recommend, if you have the time and energy, to try to contribute the implementation of the drivers you need :)
I did that for i2c because I'm using it in a project of mine. I intend to do that for PIO at some point but I have a bunch of thing to do that are higher in priority.

EDIT: If you don't have the time or energy but have some excess money, I'm sure you'd be able to find someone to work on that for a fee :P

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants