You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The rom-intrinsics PR #288 added a feature to disable intrinsics (disable_intrinsics).
Additive features are usually preferred. Should we swap this feature name to enable_intrinsics, and make it a default feature instead?
The text was updated successfully, but these errors were encountered:
I thought about this as well. Is it really an additive or subtractive feature, at all? It just changes whether it uses functions from ROM or from compiler_builtins. The functionality available to creates depending on this one stays the same.
So I think the arguments against subtractive features don't apply here.
Very true - it isn't adding functionality so there's no way that anyone can depend on it being enabled/disabled.
That resolves this in my mind, so I'll close this issue. Thanks for your input!
The rom-intrinsics PR #288 added a feature to disable intrinsics (disable_intrinsics).
Additive features are usually preferred. Should we swap this feature name to enable_intrinsics, and make it a default feature instead?
The text was updated successfully, but these errors were encountered: