Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rom-intrinsics uses 'negative' feature #293

Closed
9names opened this issue Feb 13, 2022 · 2 comments
Closed

rom-intrinsics uses 'negative' feature #293

9names opened this issue Feb 13, 2022 · 2 comments

Comments

@9names
Copy link
Member

9names commented Feb 13, 2022

The rom-intrinsics PR #288 added a feature to disable intrinsics (disable_intrinsics).
Additive features are usually preferred. Should we swap this feature name to enable_intrinsics, and make it a default feature instead?

@jannic
Copy link
Member

jannic commented Feb 13, 2022

I thought about this as well. Is it really an additive or subtractive feature, at all? It just changes whether it uses functions from ROM or from compiler_builtins. The functionality available to creates depending on this one stays the same.
So I think the arguments against subtractive features don't apply here.

@9names
Copy link
Member Author

9names commented Feb 14, 2022

Very true - it isn't adding functionality so there's no way that anyone can depend on it being enabled/disabled.
That resolves this in my mind, so I'll close this issue. Thanks for your input!

@9names 9names closed this as completed Feb 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants