Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show descriptive messages on fail to read stdin #58

Merged
merged 2 commits into from
Jan 7, 2025
Merged

Show descriptive messages on fail to read stdin #58

merged 2 commits into from
Jan 7, 2025

Conversation

dxrcy
Copy link
Contributor

@dxrcy dxrcy commented Dec 21, 2024 •
edited
Loading

When read_input fails, the panic message is now more descriptive than an anonymous unwrap.
Especially helpful for when non-terminal stdin reaches EOF.

Fixes #57.

@dxrcy dxrcy marked this pull request as ready for review December 22, 2024 10:33
rozukke
rozukke requested changes Jan 7, 2025
View reviewed changes
Copy link
Owner

@rozukke rozukke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for slow review. Should be ok after nitpick change

src/runtime.rs Show resolved Hide resolved
@rozukke rozukke merged commit ac46769 into rozukke:main Jan 7, 2025
3 checks passed
@dxrcy dxrcy deleted the fix-eof-input branch January 7, 2025 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rozukke rozukke rozukke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

IN trap triggers panic when EOF is reached
2 participants
@dxrcy @rozukke