Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Percentage Field - Add customization option #518

Closed
harinij opened this issue Sep 30, 2021 · 2 comments · Fixed by #692
Closed

Percentage Field - Add customization option #518

harinij opened this issue Sep 30, 2021 · 2 comments · Fixed by #692

Comments

@harinij
Copy link
Member

harinij commented Sep 30, 2021 •
edited
Loading

Is your feature request related to a problem? Please describe.
Currently, the "Percentage" field does have customization to change the color from red for 0% and green for 100% to anything else
Screen Shot 2021-10-01 at 2 22 33 am

Describe the solution you'd like
Ability to pick color from starting and ending percentage and mid percentage. And the color for the in between range will be auto calculated.

https://github.com/rowyio/rowy/tree/develop/src/components/fields/Percentage
@harinij harinij added the good first issue Good for newcomers label Sep 30, 2021
@htuerker
Copy link
Contributor

htuerker commented Jun 21, 2022 •
edited
Loading

I'm planning to do this implementation, just let me know if the below is a legit solution:

Screen Shot 2022-06-22 at 03 55 46

I think it's good to go, I'll make a PR tomorrow!
Screen Shot 2022-06-22 at 04 37 46

@htuerker htuerker mentioned this issue Jun 22, 2022
Merged
@notsidney notsidney linked a pull request Jun 27, 2022 that will close this issue
Feat: Percentage field color customization #692
Merged
@harinij harinij removed the good first issue Good for newcomers label Sep 14, 2022
@harinij
Copy link
Member Author

harinij commented Sep 14, 2022

This feature has been added in the latest release.

@harinij harinij closed this as completed Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feat: Percentage field color customization htuerker/rowy
2 participants
@harinij @htuerker