Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Major release v1.0.0 #9

Open
rousan opened this issue Jul 24, 2021 · 8 comments
Open

Major release v1.0.0 #9

rousan opened this issue Jul 24, 2021 · 8 comments

Comments

@rousan
Copy link
Member

rousan commented Jul 24, 2021

No description provided.

@rousan
Copy link
Member Author

rousan commented Jul 24, 2021

@gsserge @seanpianka, what do you guys think about a new major release?

@gsserge
Copy link
Member

gsserge commented Jul 26, 2021

@rousan @seanpianka I'm fairly new to stream-body and async-pipe-rs, so could you please quickly explain what needs to be merged here in order to make a 1.0.0 release and unblock routerify/stream-body#3. Thanks!

@rousan
Copy link
Member Author

rousan commented Jul 27, 2021

I have merged some major changes into develop branch e.g. Tokio version change.

@gsserge
Copy link
Member

gsserge commented Jul 28, 2021

I think we can make the release once #7 is merged.

@geigerzaehler
Copy link
Contributor

For the major release, maybe it would be a good idea to make the tokio dependency optional and make the futures dependency introduced in #7 the default? tokio is a lot more heavy weight and making futures the default would allow this library to be used with other async runtime out of the box.

@gsserge
Copy link
Member

gsserge commented Jul 28, 2021

I like the idea! Making this runtime agnostic would be great.

@gsserge
Copy link
Member

gsserge commented Aug 3, 2021

Now that #12 has landed, I'm gonna try it with https://github.com/routerify/stream-body just to make sure that things still work, and then we can make 1.0.0 release.

@rousan
Copy link
Member Author

rousan commented Aug 8, 2021

Yes, let's do this and we need to solve these blocker issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants