Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Naming, headers, and declaration changes to match style guide #66

Merged
merged 8 commits into from
Jul 11, 2024

Conversation

bsutherland333
Copy link
Collaborator

I did some cleaning and refactoring of ROSplane:

  • Matched all class, enum, struct, member variables, and function names to match ROSflight style guide
  • Organized includes to match ROSflight style guide and removed unused ones
  • Removed various unnecessary declarations/initializations
  • Fixed a wild bug where a namespace was being opened and closed in separate files

@bsutherland333 bsutherland333 requested a review from iandareid June 29, 2024 01:01
@bsutherland333 bsutherland333 self-assigned this Jun 29, 2024
@bsutherland333 bsutherland333 force-pushed the rename-classes-enums-structs branch from 8e98797 to 0a223f2 Compare June 29, 2024 01:02
@bsutherland333 bsutherland333 changed the title Rename classes enums structs Naming, headers, and declaration changes to match style guide Jul 1, 2024
Copy link
Collaborator

@iandareid iandareid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks thorough!

@bsutherland333
Copy link
Collaborator Author

@iandareid did you want me to merge this in now, or wait?

@iandareid
Copy link
Collaborator

iandareid commented Jul 10, 2024

I think perhaps we should wait. I know that the refactor of the EKF may create large conflicts. What do you think @bsutherland333?

@bsutherland333
Copy link
Collaborator Author

We can wait. I'll let you merge it in when you'd like. But I don't want to do this twice xD.

@bsutherland333
Copy link
Collaborator Author

@iandareid Is the EKF refactoring on a branch somewhere? Maybe what we should do is I can deconflict the EKF changes as they are now and then merge the refactoring in before.

@bsutherland333
Copy link
Collaborator Author

Ok I got a plan for deconfliction, just let me know when the EKF refactoring is pushed and I'll update it 😎

@bsutherland333 bsutherland333 merged commit 7a4ced0 into main Jul 11, 2024
2 checks passed
@bsutherland333 bsutherland333 deleted the rename-classes-enums-structs branch July 11, 2024 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants