From e90506e8ab73fa087cf739ab4e476acaf40e8c52 Mon Sep 17 00:00:00 2001 From: Shane Loretz Date: Tue, 12 Feb 2019 10:37:25 -0800 Subject: [PATCH] Don't validate overall actions Works around a limitation where the generation for the overall action doesn't know about messages in the same package. Signed-off-by: Shane Loretz --- rosidl_typesupport_cpp/rosidl_typesupport_cpp/__init__.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/rosidl_typesupport_cpp/rosidl_typesupport_cpp/__init__.py b/rosidl_typesupport_cpp/rosidl_typesupport_cpp/__init__.py index d3b243f5..5338e9f3 100644 --- a/rosidl_typesupport_cpp/rosidl_typesupport_cpp/__init__.py +++ b/rosidl_typesupport_cpp/rosidl_typesupport_cpp/__init__.py @@ -93,7 +93,9 @@ def generate_cpp(generator_arguments_file, type_supports): elif extension == '.action': spec = parse_action_file(pkg_name, ros_interface_file) - validate_field_types(spec, known_msg_types) + # TODO(sloretz) validate field types when overall action is generated with msg and srv + # https://github.com/ros2/rosidl/issues/348#issuecomment-462874513 + # validate_field_types(spec, known_msg_types) for template_file, generated_filename in mapping_actions.items(): generated_file = os.path.join( args['output_dir'], subfolder, generated_filename %