Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write a proper rmw_take_sequence test #176

Open
clalancette opened this issue Feb 3, 2021 · 0 comments
Open

Write a proper rmw_take_sequence test #176

clalancette opened this issue Feb 3, 2021 · 0 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@clalancette
Copy link
Contributor

While investigating the causes behind ros2/rmw_cyclonedds#279 , we discovered that there is no test within ROS 2 that actually does a rmw_take_sequence and then checks on the results. We do have a test that is pretty close: https://github.com/ros2/rcl/blob/7a25a74cf911840224fb5b992d118c22c825f961/rcl/test/rcl/test_subscription.cpp#L388 . That initializes the sequence, fills it with messages, and then calls rcl_take_sequence.

It would be nice to have another variant of this test in this repository which specifically deals with rmw_take_sequence.

@hidmic hidmic added good first issue Good for newcomers help wanted Extra attention is needed labels Feb 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants