-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement the rmw_get_publishers_info_by_topic and rmw_get_subscriptions_info_by_topic methods #82
Comments
@ivanpauno have you already started implementing this? If not: I can make some time next week to implement these 2 methods. |
I didn't start. I assigned myself because after moving the Also, I'm not sure if we're going to do the refactor I previously mention in |
@ivanpauno I've implemented these two functions based on the current state wrt participant mapping. In case an update of these functions is required after the refactoring you mentioned, I'm happy to do that. In ros2/rcl#571 I've enabled the tests for Cyclone |
@dennis-adlink Thanks for opening this! It would be good if somebody from adlink can review #97, as I don't have much time now for doing a thorough review right (I would be able to do it in a few weeks). |
This issue has been resolved with the completion of #97. |
As a follow up to #81, which currently returns
RMW_RET_UNSUPPORTED
for thermw_get_publishers_info_by_topic()
andrmw_get_subscriptions_info_by_topic()
functions, ensure that these methods are implemented before the ROS2 Foxy release.These methods are implemented for rmw_fastrtps in ros2/rmw_fastrtps#336, which can be used as a reference.
The text was updated successfully, but these errors were encountered: