Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rclcpp] refactor Executor::add_callback_group to not need a node pointer #1287

Open
wjwwood opened this issue Sep 2, 2020 · 0 comments
Open
Assignees
Labels
enhancement New feature or request

Comments

@wjwwood
Copy link
Member

wjwwood commented Sep 2, 2020

In #1218 the add_callback_group() method was added, but it required us to pass the node associated with the callback group as well, because it was still needed internally in the executor and because the callback group doesn't have a back reference to the node that created it.

We need to change this so it is no longer required because the library can have all this information and asking the user to provide it is redundant and can only lead to misuse, i.e. it has no practical value or serves no extra use case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant