Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a way of grouping remapping rules and parameters #45

Closed
ivanpauno opened this issue Jul 25, 2019 · 2 comments · Fixed by #158 or #163
Closed

Add a way of grouping remapping rules and parameters #45

ivanpauno opened this issue Jul 25, 2019 · 2 comments · Fixed by #158 or #163
Assignees
@ivanpauno
Labels
enhancement New feature or request

Comments

@ivanpauno
Copy link
Member

Feature request

Feature description

We don't have a SetRemapping action.
It could be useful, is the same remapping has to be applied in many nodes.

Implementation considerations

We could store them in the LaunchContext. The group action will do its magic for limiting their scope.

Previous discussion: ros2/ros2_documentation#302 (comment)

We could do something similar for parameters.
But it won't set a global parameter, as in ROS 1, but it'll set the same parameter in each node in the scope.

Previous discussion:
ros2/ros2_documentation#302 (comment)
@ivanpauno ivanpauno added enhancement New feature or request help wanted Extra attention is needed labels Jul 25, 2019
@ivanpauno ivanpauno mentioned this issue Jul 25, 2019
Merged
@ivanpauno ivanpauno removed the help wanted Extra attention is needed label Jun 24, 2020
@ivanpauno ivanpauno self-assigned this Jun 24, 2020
@ivanpauno ivanpauno changed the title Add a way of grouping remappings (and parameters) Add a way of grouping remapping rules and parameters Jun 24, 2020
@ivanpauno
Copy link
Member Author

I've started to implement this for parameters.

@ivanpauno ivanpauno mentioned this issue Jun 25, 2020
Merged
@ivanpauno
Copy link
Member Author

reopening, as a similar feature for remapping rules is still needed

@ivanpauno ivanpauno reopened this Jul 1, 2020
@ivanpauno ivanpauno mentioned this issue Jul 23, 2020
Merged
@ivanpauno ivanpauno mentioned this issue Aug 5, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ivanpauno ivanpauno

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
1 participant
@ivanpauno