-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conditional includes #303
Comments
Yeap, that's a bug. Current implementation is not forwarding (nor taking) additional |
I haven't checked, but this may be also true for other actions. It may be a good idea to go over the arguments for all actions. |
@chapulina and I tried making a subclass of |
True that, |
Bug report
Required Info:
Steps to reproduce issue
While working on ros-simulation/gazebo_ros_pkgs#962, we wanted to conditionally add the
IncludeLaunchDescription
action using thecondition
keyword. But that action is not accepting the keyword.Here's a simple example with 2 files:
main.launch.py
included.launch.py
Expected behavior
main.launch.py
printsmain.launch.py do:=false
prints nothingActual behavior
[ERROR] [launch]: Caught exception in launch (see debug for traceback): __init__() got an unexpected keyword argument 'condition'
Additional information
Commenting out the
condition
insideIncludeLaunchDescription
lets the program run, butincluded
is always printed.The text was updated successfully, but these errors were encountered: