Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Python 3.5.2 (Xenial)? #195

Closed
jacobperron opened this issue Mar 6, 2019 · 3 comments
Closed

Support Python 3.5.2 (Xenial)? #195

jacobperron opened this issue Mar 6, 2019 · 3 comments
Assignees
Labels
more-information-needed Further information is required

Comments

@jacobperron
Copy link
Member

Feature request

Feature description

Until recently, launch was compatible with Python 3.5.2, which is the current default version for python3 on Ubuntu Xenial, but now is broken.

#167, introduced the following line:

from typing import Coroutine

Coroutine is not available in the typing module until Python 3.5.3 (reference).

I think it's an easy fix as we can use something like TypeVar('Coroutine') as a replacement.
But, I'm not sure if we plan to support Xenial in Dashing and/or if we'd like to keep launch backwards compatible (given that it's an easy fix).

@jacobperron jacobperron added the more-information-needed Further information is required label Mar 6, 2019
@dirk-thomas
Copy link
Member

Duplicate of ros2/build_farmer#170.

@jacobperron jacobperron self-assigned this Mar 7, 2019
@jacobperron jacobperron added the in progress Actively being worked on (Kanban column) label Mar 7, 2019
@jacobperron
Copy link
Member Author

Duplicate of ros2/build_farmer#170.

@dirk-thomas Okay. What do you think about #196 as an alternate solution? I've been using it locally as I'm running Xenial. But I don't mind upgrading to Bionic if we're dropping support for Xenial.

@jacobperron
Copy link
Member Author

I've seen your comment in #196 👍

@jacobperron jacobperron removed the in progress Actively being worked on (Kanban column) label Mar 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
more-information-needed Further information is required
Projects
None yet
Development

No branches or pull requests

2 participants