Skip to content
This repository has been archived by the owner on Feb 4, 2021. It is now read-only.

colcon installed on windows machines #105

Closed
dhood opened this issue Apr 2, 2018 · 3 comments
Closed

colcon installed on windows machines #105

dhood opened this issue Apr 2, 2018 · 3 comments

Comments

@dhood
Copy link
Member

dhood commented Apr 2, 2018

@dirk-thomas could you please remove colcon from any machines you installed it on for testing? (AFAIU we don't want it installed by default at the moment)
e.g. portable has it installed https://ci.ros2.org/job/ci_windows/4268/consoleFull

@dirk-thomas
Copy link
Member

I could uninstall the package but any time a build is being run with the colcon branch of the CI repo the packages are being installed since we don't use a build specific virtual env on Windows. What is the problem with them being installed but not being used?

@dhood
Copy link
Member Author

dhood commented Apr 2, 2018

I didn't realise we never use virtual environments on windows! My thinking was that it might accidentally mess with things (this is true for any non-default package), and not knowing that it's installed would mean that we overlook it/other "stealth" packages as potential causes of any unexpected behaviour. If we never use virtual environments then I see your point that it will just keep getting installed, so for now it probably makes more sense to highlight its stealth status :)

I'll use this ticket to track that it is installed on (some?) windows machines

@dhood dhood changed the title colcon installed in windows builds colcon installed on windows machines Apr 2, 2018
@clalancette
Copy link

@dhood @dirk-thomas colcon is intentionally installed on the Windows machines now, so I'm going to close this. Feel free to re-open if I made a mistake.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants