Add humble to Linux CI
#98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoffmann-stefan
force-pushed
the
feature/ubuntu22.04-ci
branch
2 times, most recently
from
f067e6e to
8a1d76b
Compare
hoffmann-stefan
force-pushed
the
feature/ubuntu22.04-ci
branch
4 times, most recently
from
9a6d29d to
1d7f786
Compare
seems like it is already installed in the default github image, see https://github.com/actions/runner-images/blob/main/images/linux/Ubuntu2204-Readme.md
This removes the hack with replacing the ros distribution via sed in the build_linux.yaml. Updated the readme to be consistent about mentioned ros distributions as well.
This should fix builds on ubuntu-22.04. - see https://stackoverflow.com/a/75855054 - see ied206/Joveler.DynLoader#1 for other dotnet library with the same issue
hoffmann-stefan
force-pushed
the
feature/ubuntu22.04-ci
branch
from
1d7f786 to
eaea459
Compare
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends on ros2-dotnet/dotnet_cmake_module#4👈 already mergedThis started as do a minimal change to test Ubuntu 22.04, but did involve some more tasks on the way:
ubuntu-20.04andubuntu-22.04.ubuntu-20.04👉 Add humble to ci.ubuntu-22.04, use .NET 6 instead.netcoreapp2.0by default 👉 Make PR indotnet_cmake_moduleto be able to specify theTARGET_FRAMEWORKfor tests.ubuntu-22.04withlibdl.so[.2].foxybuild to use .NET 6 as .NET Core 2.1 is not supported anymore.While were at it addrollingas a bonusOverview of supported .NET versions on Ubuntu
https://learn.microsoft.com/en-us/dotnet/core/install/linux-ubuntu#supported-distributions
Going with .NET 6 for Ubuntu 22.04 from the Microsoft package feed.👉 Causes issues with the already installed .NET 6 SDK in the github actionsubuntu-22.04image. So use the already installed one.