From 827163b79dc338ce23886559c24ca81b03c8468e Mon Sep 17 00:00:00 2001 From: Silvio Traversaro Date: Tue, 7 Nov 2023 10:01:39 +0100 Subject: [PATCH 1/2] Create sdformat_urdf_plugin as SHARED instead of MODULE for macOS compatibility --- sdformat_urdf/CMakeLists.txt | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/sdformat_urdf/CMakeLists.txt b/sdformat_urdf/CMakeLists.txt index 5c82e21..e1026c2 100644 --- a/sdformat_urdf/CMakeLists.txt +++ b/sdformat_urdf/CMakeLists.txt @@ -69,7 +69,9 @@ target_include_directories(sdformat_urdf ) # Add sdformat_urdf_plugin module library -add_library(sdformat_urdf_plugin MODULE +# not actually a MODULE as workaround for +# https://github.com/ros/pluginlib/issues/200 +add_library(sdformat_urdf_plugin SHARED src/sdformat_urdf_plugin.cpp ) target_link_libraries(sdformat_urdf_plugin PRIVATE From cf8d7a90c254210cf964db02f771a9c3bc2fee9e Mon Sep 17 00:00:00 2001 From: Silvio Traversaro Date: Sat, 11 Nov 2023 11:38:14 +0100 Subject: [PATCH 2/2] Remove trailing whitespace --- sdformat_urdf/CMakeLists.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sdformat_urdf/CMakeLists.txt b/sdformat_urdf/CMakeLists.txt index e1026c2..b2eec75 100644 --- a/sdformat_urdf/CMakeLists.txt +++ b/sdformat_urdf/CMakeLists.txt @@ -69,7 +69,7 @@ target_include_directories(sdformat_urdf ) # Add sdformat_urdf_plugin module library -# not actually a MODULE as workaround for +# not actually a MODULE as workaround for # https://github.com/ros/pluginlib/issues/200 add_library(sdformat_urdf_plugin SHARED src/sdformat_urdf_plugin.cpp