Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opencv-contrib-python added to rosdep/python.yaml #43173

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

pep248
Copy link
Contributor

@pep248 pep248 commented Oct 14, 2024

Please add the following dependency to the rosdep database.

Package name:

opencv-contrib-python

Package Upstream Source:

opencv-contrib-python

Purpose of using this:

Some libraries for marker detection in OpenCV are only available in said package.
This package is automatically installed when using pip install opencv-python but not when using apt-get install python-opencv or apt-get install python3-opencv.
Since the request to make OpenCV installable through pip was discarded here, I would like to, at least, have the opencv-contrib-python package available.

Distro packaging links:

Links to Distribution Packages

@pep248 pep248 requested a review from a team as a code owner October 14, 2024 13:21
@github-actions github-actions bot added the rosdep Issue/PR is for a rosdep key label Oct 14, 2024
Copy link
Contributor

@methylDragon methylDragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay because I do not see an Python opencv-contrib package on the debian package or ubuntu lists

Copy link

github-actions bot commented Nov 1, 2024

This PR hasn't been activity in 14 days. If you are still are interested in getting it merged please provide an update. Otherwise it will likely be closed by a rosdistro maintainer following our contributing policy. It's been labeled "stale" for visibility to the maintainers. If this label isn't appropriate, you can ask a maintainer to remove the label and add the 'persistent' label.

@github-actions github-actions bot added the stale Issue/PR hasn't been active in a while and may be closed. label Nov 1, 2024
@pep248
Copy link
Contributor Author

pep248 commented Nov 3, 2024

Why stale?
What else do I need for the merge to be successfull?

@github-actions github-actions bot removed the stale Issue/PR hasn't been active in a while and may be closed. label Nov 4, 2024
@agonzat
Copy link
Contributor

agonzat commented Nov 14, 2024

Hi, what is blocking this pr?

Copy link
Contributor

@sloretz sloretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Standard pip disclaimer: ROS packages that depend on pip keys cannot be released into a ROS distribution. They can only be depended on by from-source builds. Because of this, system packages are highly preferred to pip packages.

@nuclearsandwich nuclearsandwich merged commit 135c99a into ros:master Nov 21, 2024
4 checks passed
@pep248 pep248 deleted the patch-1 branch November 21, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rosdep Issue/PR is for a rosdep key
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants